Fix access list enterprise tests.#30925
Merged
Merged
Conversation
The access list enterprise tests were broken by changing the custom JSON
marshaling of the access list audit from `map[string]interface{}` to
`map[string]string`. This change restores the old behavior.
rudream
approved these changes
Aug 23, 2023
jakule
approved these changes
Aug 23, 2023
Contributor
|
BTW, wouldn't make more sense to update the tests in |
Contributor
Author
I was originally attempting to fix the tests in |
tigrato
reviewed
Aug 23, 2023
|
|
||
| func (a *Audit) UnmarshalJSON(data []byte) error { | ||
| var audit map[string]string | ||
| var audit map[string]interface{} |
Contributor
There was a problem hiding this comment.
It's already merged but why don't you just use a temp struct to unmarshal these values. The unmarshal to map[string]any is not good when we know the types and fields.
Extending to other fields isn't trivial and the current form is quite difficult to understand
Contributor
Author
There was a problem hiding this comment.
I'm happy to look into that as a follow on PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The access list enterprise tests were broken by changing the custom JSON marshaling of the access list audit from
map[string]interface{}tomap[string]string. This change restores the old behavior.